Various patches submitted by email/forums


ACTIVE-IST JAUS++ and CxUtils (v2.110519)

make-joystick-frequency-field-do-something.patch
Make the update frequency field in the CxUtils::Joystick XML configuration settings actually have an effect.

Setting-the-MaxPacketSizeBites-conf-parameter-breaks.patch
In JTCPClient::LoadSettings and JUDP::LoadSettings, mMaxPayloadSize gets assigned the direct value represented in the MaxPacketSizeBytes field. But they should instead be calling SetMaxPacketSize(), which subtracts some bytespace for overhead before assigning the payload size. Without this change, using the MaxPacketSizeBites configuration field causes transport to fail silently because all packets are dropped as too large after assembly.

[Submitted by email to Daniel Barber at the ACTIVE Lab at UCF]


jQuery ContextMenu (r2)

disable-contextmenu-in-contextmenu.patch
Fix a small bug in the simple jQuery ContextMenu plugin from http://trendskitchens.co.nz/jquery/contextmenu/ where right-clicking on the contextmenu pop-up shows the browser's default contextmenu.

[Submitted by email to Chris Domigan]


GNU Midnight Commander (v4.8.10)

0001-Live-update-the-panels-when-editing-layout.patch
Live-update the panel split while adjusting the layout dialog, because the user should not be expected to know what number of columns or rows is reasonable without being able to see the effects. Cancel reverts to previous settings.

0002-Make-layout-dialog-left-right-arrows-more-coherent.patch
alt+shift+left_arrow and alt+shift+right_arrow directly influence the divider position, but the < and > layout dialog buttons have the reverse effect, which is unintuitive behavior. Reverse the direction of < and > influence so that clicking left moves the divider left, and clicking right moves the divider right.

0003-Fix-en-dis-abling-of-layout-split-adjust-buttons.patch
Switching between vertical and horizontal layouts doesn't properly activate or deactivate the < and > widget buttons in the layout dialog according to the "equal split" setting of the mode being switched to.

[Submitted with http://www.midnight-commander.org/ticket/3060 and http://www.midnight-commander.org/ticket/3061]


PowerTop (v1.13)

0001-The-code-for-powertop-always-suggests-cat-ing-to-hos.patch
host0/link_power_management_policy has min_power, but host1/... et al have max_performance, so powertop complains about host0 because it's a hardcoded string. This patch correctly tells the user why powertop is complaining, by informing to set power settings on all instead of just host0.

0002-This-patch-makes-powertop-only-look-at-the-power-sta.patch
This patch makes powertop only look at the power state of SATA devices that have attached disks, so that it doesn't repeatedly complain about /sys/class/scsi_host/host*/link_power_management_policy because it looks through all of host* but does not have the ability to set min_power for all of them, because the kernel ignores such attempts to change many of them without reporting an error. This way powertop will only report errors that the user can actually fix.
Please don't actually use this code. It works, but it is very ridiculous. :-D
It should be taken as inspiration, and not used verbatim.

[Submitted by email to Auke Kok as a not-so-serious-but-very-real fix for https://bugs.launchpad.net/ubuntu/+source/powertop/+bug/305895]

[23:29:12] <paulproteus> nwf + vsrinivas: http://temporary_patch_two_url
[23:29:28] <paulproteus> Avi (a Bostonian) and I would appreciate feedback on this patch.
[23:37:09] <nwf> paulproteus: "Oh dear."
[23:37:20] <paulproteus> :D
[23:37:21] <vsrinivas> paulproteus: could you point to the source tree it is patching? (powertop or linux?)
[23:37:25] <paulproteus> powertop
[23:37:52] <paulproteus> Sure, http://git.moblin.org/cgit.cgi/powertop/
[23:40:11] <vsrinivas> ... no. <diff>:46.
[23:42:08] <paulproteus> Oh, it fails to apply? You might need an earlier patch that we made, which for no good reason we didn't make an independent branch.
[23:42:27] <paulproteus> So this one (in our git history, before git-format-patch) depends on that one.
[23:42:48] -*- paulproteus fixes; one sec
[23:43:25] <vsrinivas> i'm just complaining about line 46.
[23:43:30] <vsrinivas> in the diff.
[23:43:53] <paulproteus> Yeah, we could have done it with sed, I realize now.
[23:44:05] -*- paulproteus just checked, and it does apply.
[23:44:18] <paulproteus> Also we introduce a memory leak, and this function is called once every 5-20s.
[23:44:23] <Triskelios> I have no comments
[23:44:29] <Triskelios> the patch is perfect 


MUSHclient

4.70

4.70-improve-miniwindow-offscreen-handling.patch
Making miniwindows jump back to the old location after release is unintuitive behavior. If a position is going to be used, it should be evident right away.

[Submitted via forum post: http://www.mushclient.com/forum/?id=10789]

4.70-fix-gauge-display-errors.patch
gauge.lua draws the bar wider than the border, and hotspots don't get redone if the miniwindow is resized and the gauges are redrawn in different places.

[Submitted via forum post: http://www.mushclient.com/forum/?id=10759

4.73

4.73-do_plugin_check_now-should-also-validate-enabled-state.patch
checkplugin.lua's do_plugin_check_now function only checks that a plugin is installed, but doesn't make sure that it is enabled. This makes it also check for enabled status.

[Submitted via forum post: http://www.mushclient.com/forum/?id=11145]

4.75

4.75-allow-specifying-miniwindow-initial-position.patch
Add the ability to set an exact initial position for new miniwindows.

[Submitted via forum post: http://www.mushclient.com/forum/?id=11241]

4.82

4.82-save-right-position-when-many-plugins-manipulate-one-miniwindow.patch
When multiple plugins allow dragging of a single shared miniwindow, the wrong miniwindow position can get saved. So we should save the current actual position rather than the plugin's stored idea of what the position is, because plugins don't share state with each other.

[Submitted via forum post: http://www.mushclient.com/forum/?id=11765]

4.84

4.84-give-meaningful-information-instead-of-asserts.patch
Assertion error tracebacks are big and scary for uninformed users, so present a friendlier message with helpful troubleshooting information.

[Submitted via forum post: http://www.mushclient.com/forum/?id=11803]

4.90

4.90-fix-gradient-alignment-and-add-flat-options-to-gauge.patch
Fix the single pixel vertical misalignment in drawing gauge gradients, and add a flat drawing option that skips the gradient. Also add a function for printing outlined text, because there's no way to put a single text color on a gradient that won't look bad.

[Submitted via forum post: http://www.mushclient.com/forum/?id=11951]